linux-kernel - Re: [PATCH v2 2/2] lib/string.c: Add wcslen()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250326223554.GB378784@ax162>
Date: Wed, 26 Mar 2025 15:35:54 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Kees Cook <kees@...nel.org>, Andy Shevchenko <andy@...nel.org>,
	Nick Desaulniers <nick.desaulniers+lkml@...il.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>,
	Ard Biesheuvel <ardb@...nel.org>, linux-kernel@...r.kernel.org,
	linux-hardening@...r.kernel.org, llvm@...ts.linux.dev,
	stable@...r.kernel.org
Subject: Re: [PATCH v2 2/2] lib/string.c: Add wcslen()

On Wed, Mar 26, 2025 at 08:39:37PM +0200, Andy Shevchenko wrote:
> On Wed, Mar 26, 2025 at 7:19 PM Nathan Chancellor <nathan@...nel.org> wrote:
> >  #ifndef __HAVE_ARCH_STRNLEN
> >  extern __kernel_size_t strnlen(const char *,__kernel_size_t);
> >  #endif
> > +extern __kernel_size_t wcslen(const wchar_t *s);
> 
> I'm wondering why we still continue putting this 'extern' keyword.
> Yes, I see that the rest is like this, but for new code do we really
> need it?

Yeah, I just did it to keep it consistent with what is around it but
there should be no reason that it cannot be removed. I am happy to do
that in v3 if desired.

Cheers,
Nathan