linux-kernel - Re: [PATCH v1 8/8] arm64: dts: qcom: qcm6490-idp: Add sound card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2a9df021-72f7-4bcd-8c93-634c2b77dfe1@linaro.org>
Date: Wed, 26 Mar 2025 23:12:07 +0000
From: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To: Prasad Kumpatla <quic_pkumpatl@...cinc.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: cros-qcom-dts-watchers@...omium.org, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 kernel@....qualcomm.com, Mohammad Rafi Shaik <quic_mohs@...cinc.com>
Subject: Re: [PATCH v1 8/8] arm64: dts: qcom: qcm6490-idp: Add sound card

On 17/03/2025 05:41, Prasad Kumpatla wrote:
> Add the sound card node with tested playback over WSA8835 speakers,
> msm mic along with wcd9370 headset playabck and record.

I think as a reviewer I'd like a better description.

"msm mic" doesn't mean much - please specify the number of MICs and 
their type - "four digital mics"

MSM Mics are not a meaningful description.

---
bod