[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5l4pjqlgu4afndn3ysa7ynecjmvepkfjlh56ycm5jt5e4mioqm@dujakwaomhlk>
Date: Wed, 26 Mar 2025 13:16:20 +0900
From: Sergey Senozhatsky <senozhatsky@...omium.org>
To: Richard Chang <richardycc@...gle.com>
Cc: Minchan Kim <minchan@...nel.org>,
Sergey Senozhatsky <senozhatsky@...omium.org>, Andrew Morton <akpm@...ux-foundation.org>,
Brian Geffon <bgeffon@...gle.com>, linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] zram: modernize writeback interface
Hi,
On (25/03/26 12:03), Richard Chang wrote:
> Hi Sergey,
> Since the input buffer length is only PAGE_SIZE long, can we reduce
> the duplicated "page_index_range=" strings?
> Eg:
> Turn
> echo page_index_range=100-200 \
> page_index_range=500-700 > zram0/writeback
> To:
> echo page_index_range=100-200,500-700 > zram0/writeback
Do you expect to ever have so many ranges that PAGE_SIZE buffer
would be too small? I didn't want to put a list parser into
the kernel, I wanted to keep arguments parsing as simple as
possible. But if you really need to writeback that many pages
then I guess I can implement it as a list of ranges.
Alternatively:
We don't necessarily need to use page_index_range key, which is a
little long, but can use page_indices=/page_indexes= or just pages=?
Powered by blists - more mailing lists