linux-kernel - Re: [PATCH] x86/smpboot: Remove duplicate include of asm/spec-ctrl.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250326140706565JjKrEqMj_k5dCy15Ru2jP@zte.com.cn>
Date: Wed, 26 Mar 2025 14:07:06 +0800 (CST)
From: <xu.xin16@....com.cn>
To: <shao.mingyin@....com.cn>
Cc: <tglx@...utronix.de>, <peterz@...radead.org>,
        <linux-kernel@...r.kernel.org>, <yang.yang29@....com.cn>,
        <ye.xingchen@....com.cn>
Subject: Re: [PATCH] x86/smpboot: Remove duplicate include of asm/spec-ctrl.h

>From: Feng Wei <feng.wei8@....com.cn>
>
>The header file <asm/spec-ctrl.h> is included twice in smpboot.c.
>This is harmless due to include guards, but redundant. Remove the duplicate
>inclusion to clean up the code.
>
>Signed-off-by: Feng Wei <feng.wei8@....com.cn>
>Signed-off-by: Shao Mingyin <shao.mingyin@....com.cn>
>---
>arch/x86/kernel/smpboot.c | 1 -
>1 file changed, 1 deletion(-)
>
>diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
>index d6cf1e23c2a3..1dd0299da294 100644
>--- a/arch/x86/kernel/smpboot.c
>+++ b/arch/x86/kernel/smpboot.c
>@@ -89,7 +89,6 @@
>#include <asm/hw_irq.h>
>#include <asm/stackprotector.h>
>#include <asm/sev.h>
>-#include <asm/spec-ctrl.h>
>
>/* representing HT siblings of each logical CPU */
>DEFINE_PER_CPU_READ_MOSTLY(cpumask_var_t, cpu_sibling_map);
>--
>2.25.1
>
Tested, it's ok.

Reviewed-by: xu xin <xu.xin16@....com.cn>