linux-kernel - Re: [PATCH] net/mlx5: DR, remove redundant object

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <91285e69-91d6-4845-8381-46b55cb98d22@gmail.com>
Date: Wed, 26 Mar 2025 08:13:00 +0200
From: Tariq Toukan <ttoukan.linux@...il.com>
To: Qasim Ijaz <qasdev00@...il.com>, saeedm@...dia.com, leon@...nel.org,
 tariqt@...dia.com, andrew+netdev@...n.ch, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, kliteyn@...dia.com
Cc: netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/mlx5: DR, remove redundant object_range assignment



On 24/03/2025 21:41, Qasim Ijaz wrote:
> The initial assignment of object_range from
> pool->dmn->info.caps.log_header_modify_argument_granularity is
> redundant because it is immediately overwritten by the max_t() call.
> 
> Remove the unnecessary assignment.
> 
> Signed-off-by: Qasim Ijaz <qasdev00@...il.com>
> ---
>   drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c
> index 01ed6442095d..c2218dc556c7 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c
> @@ -39,9 +39,6 @@ static int dr_arg_pool_alloc_objs(struct dr_arg_pool *pool)
>   
>   	INIT_LIST_HEAD(&cur_list);
>   
> -	object_range =
> -		pool->dmn->info.caps.log_header_modify_argument_granularity;
> -
>   	object_range =
>   		max_t(u32, pool->dmn->info.caps.log_header_modify_argument_granularity,
>   		      DR_ICM_MODIFY_HDR_GRANULARITY_4K);

Acked-by: Tariq Toukan <tariqt@...dia.com>

Thanks for your patch.
This is net-next material. Please specify target branch in future 
submissions.

Regards,
Tariq