linux-kernel - Re: [PATCH 12/34] mfd: sec: add support for S2MPG10 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <25eb9c47-96ba-4037-b320-af16e0226f4c@kernel.org>
Date: Wed, 26 Mar 2025 08:22:55 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: André Draszik <andre.draszik@...aro.org>,
 Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Sylwester Nawrocki <s.nawrocki@...sung.com>,
 Chanwoo Choi <cw00.choi@...sung.com>, Alim Akhtar <alim.akhtar@...sung.com>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Russell King <linux@...linux.org.uk>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc: Peter Griffin <peter.griffin@...aro.org>,
 Tudor Ambarus <tudor.ambarus@...aro.org>,
 Will McVicker <willmcvicker@...gle.com>, kernel-team@...roid.com,
 linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
 devicetree@...r.kernel.org, linux-clk@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rtc@...r.kernel.org
Subject: Re: [PATCH 12/34] mfd: sec: add support for S2MPG10 PMIC

On 23/03/2025 23:39, André Draszik wrote:
> Add support for Samsung's S2MPG10 PMIC, which is a Power Management IC
> for mobile applications with buck converters, various LDOs, power
> meters, RTC, clock outputs, and additional GPIOs interfaces.
> 
> Contrary to existing Samsung S2M series PMICs supported, communication
> is not via I2C, but via the Samsung ACPM firmware.
> 
> This commit adds the core driver.
> 
> Signed-off-by: André Draszik <andre.draszik@...aro.org>
> 
> ---
> Checkpatch suggests to update MAINTAINERS, but the new file is covered
> already due to using a wildcard.
> ---

I did a quick look and seems fine, but I suspect small rework when PMIC
becames child of ACPM, so full review later.

Best regards,
Krzysztof