linux-kernel - Re: [PATCH] modified: sound/pci/hda/patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87cye4b6bk.wl-tiwai@suse.de>
Date: Wed, 26 Mar 2025 08:26:55 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Sharwesh05 <sharweshraajan@...il.com>
Cc: tiwai@...e.com,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] 	modified:   sound/pci/hda/patch_realtek.c

On Tue, 25 Mar 2025 16:05:10 +0100,
Sharwesh05 wrote:
> 

Thanks for the patch.

But, please make the patch in a proper format, namely, have the
appropriate Subject line starting with the prefix "ALSA: hda/realtek:"
and containing the concise description about the patch.  Then put more
information about the changes (why it's needed and what it fixes /
changes) in the patch description, followed by a blank line, and most
importantly, your Signed-off-by tag with your real name and address;
it's a legal requirement.

Please check Documentation/admin/submitting-patches.rst for details.

About the code change:

> ---
>  sound/pci/hda/patch_realtek.c | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index a84857a3c2bf..8c2375476952 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -4739,6 +4739,21 @@ static void alc245_fixup_hp_mute_led_coefbit(struct hda_codec *codec,
>  		snd_hda_gen_add_mute_led_cdev(codec, coef_mute_led_set);
>  	}
>  }
> +static void alc245_fixup_hp_mute_led_v1_coefbit(struct hda_codec *codec,
> +					    const struct hda_fixup *fix,
> +						int action)

Put a blank line before the function.

Could you correct the above and resubmit?

thanks,

Takashi