linux-kernel - Re: [PATCH v5 02/13] dt-bindings: clock: Add cpg for the Renesas RZ/T2H SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250326-enigmatic-cuscus-of-enhancement-410130@krzk-bin>
Date: Wed, 26 Mar 2025 08:49:57 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Thierry Bultel <thierry.bultel.yh@...renesas.com>
Cc: thierry.bultel@...atsea.fr, linux-renesas-soc@...r.kernel.org, 
	geert@...ux-m68k.org, paul.barker.ct@...renesas.com, 
	Geert Uytterhoeven <geert+renesas@...der.be>, linux-clk@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 02/13] dt-bindings: clock: Add cpg for the Renesas
 RZ/T2H SoC

On Tue, Mar 25, 2025 at 05:08:50PM +0100, Thierry Bultel wrote:
> Document RZ/T2H (a.k.a r9a09g077) cpg-mssr (Clock Pulse Generator) binding.
> 
> Signed-off-by: Thierry Bultel <thierry.bultel.yh@...renesas.com>
> ---
> Changes v4->v5:
>   - Set reg minItems and maxItems defaults at top level
> Changes v3->v4:
>   - Handle maxItems and clocks names properly in schema. 


Can you start using b4 or send patchsets in standard way? No links to
previous versions in changelog and b4 diff does not work:

b4 diff '20250325160904.2688858-1-thierry.bultel.yh@...renesas.com'
Grabbing thread from lore.kernel.org/all/20250325160904.2688858-1-thierry.bultel.yh@...renesas.com/t.mbox.gz
Checking for older revisions
Grabbing search results from lore.kernel.org
  Added from v4: 14 patches
---
Analyzing 140 messages in the thread
Preparing fake-am for v4: dt-bindings: soc: Add Renesas RZ/T2H (R9A09G077) SoC
ERROR: Could not fake-am version v4
---
Could not create fake-am range for lower series v4


> ---
>  .../bindings/clock/renesas,cpg-mssr.yaml      | 55 +++++++++++++------
>  .../clock/renesas,r9a09g077-cpg-mssr.h        | 49 +++++++++++++++++
>  2 files changed, 88 insertions(+), 16 deletions(-)
>  create mode 100644 include/dt-bindings/clock/renesas,r9a09g077-cpg-mssr.h
> 
> diff --git a/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml b/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml
> index 77ce3615c65a..5181ff826dbe 100644
> --- a/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml
> +++ b/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml
> @@ -52,9 +52,11 @@ properties:
>        - renesas,r8a779f0-cpg-mssr # R-Car S4-8
>        - renesas,r8a779g0-cpg-mssr # R-Car V4H
>        - renesas,r8a779h0-cpg-mssr # R-Car V4M
> +      - renesas,r9a09g077-cpg-mssr # RZ/T2H
>  
>    reg:
> -    maxItems: 1
> +    minItems: 1
> +    maxItems: 2
>  
>    clocks:
>      minItems: 1
> @@ -63,11 +65,6 @@ properties:
>    clock-names:
>      minItems: 1
>      maxItems: 2
> -    items:
> -      enum:
> -        - extal     # All
> -        - extalr    # Most R-Car Gen3 and RZ/G2
> -        - usb_extal # Most R-Car Gen2 and RZ/G1
>  
>    '#clock-cells':
>      description: |
> @@ -92,16 +89,6 @@ properties:
>        the datasheet.
>      const: 1
>  
> -if:
> -  not:
> -    properties:
> -      compatible:
> -        items:
> -          enum:
> -            - renesas,r7s9210-cpg-mssr
> -then:
> -  required:
> -    - '#reset-cells'
>  
>  required:
>    - compatible
> @@ -113,6 +100,42 @@ required:
>  
>  additionalProperties: false
>  
> +allOf:

This goes befoer additionalProps. See example-schema.

> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: renesas,r9a09g077-cpg-mssr
> +    then:
> +      properties:
> +        reg:
> +          minItems: 2

Missing constriants for clocks.

Best regards,
Krzysztof