linux-kernel - Re: [PATCH] staging: rtl8723bs: remove braces around single statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADYq+fYD3LVvBJCYizjG2DR4SMMC+V0Pff0zXKb8rLw2ej0jdg@mail.gmail.com>
Date: Wed, 26 Mar 2025 10:00:19 +0100
From: Samuel Abraham <abrahamadekunle50@...il.com>
To: Julia Lawall <julia.lawall@...ia.fr>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, outreachy@...ts.linux.dev, 
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: remove braces around single statements

On Wed, Mar 26, 2025 at 9:26 AM Julia Lawall <julia.lawall@...ia.fr> wrote:
>
>
>
> On Tue, 25 Mar 2025, Abraham Samuel Adekunle wrote:
>
> > The code contains braces around single statements in the if blocks
> > which are unnecessary according to the Linux kernel coding style.
> >
> > Remove the braces to improve readability and maintain consistency.
> >
> > Reported by checkpatch:
> >
> > WARNING: braces {} are not necessary for single statement blocks
> >
> > Signed-off-by: Abraham Samuel Adekunle <abrahamadekunle50@...il.com>
> > ---
> >  drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> > index c60e179bb2e1..b17b295e8d3c 100644
> > --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> > +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> > @@ -56,9 +56,9 @@ int _ips_leave(struct adapter *padapter)
> >               pwrpriv->ips_leave_cnts++;
> >
> >               result = rtw_ips_pwr_up(padapter);
> > -             if (result == _SUCCESS) {
> > +             if (result == _SUCCESS)
> >                       pwrpriv->rf_pwrstate = rf_on;
> > -             }
> > +
>
> I'm not sure you need to add a blank line here?
>
> julia
>

Thank you for your review. I will effect the change