linux-kernel - Re: [PATCH 2/2] drm/mode_config: Make drm_mode_config.(max|min)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <888333e6-e81c-4186-b543-78fda7e3eb68@suse.de>
Date: Wed, 26 Mar 2025 10:32:25 +0100
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Lyude Paul <lyude@...hat.com>, Maxime Ripard <mripard@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>
Subject: Re: [PATCH 2/2] drm/mode_config: Make
 drm_mode_config.(max|min)_(width|height) signed

Hi

Am 25.03.25 um 22:27 schrieb Lyude Paul:
> Similarly, it doesn't really make much sense for us to allow devices to
> specify their minimum/maximum resolution as signed. So, let's fix that as
> well while we're at it.

This commit message only makes sense in the context of the series. 
Better remove 'Similarily' and 'as well while we're at it'.

>
> Signed-off-by: Lyude Paul <lyude@...hat.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Maxime Ripard <mripard@...nel.org>
> ---
>   include/drm/drm_mode_config.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h
> index 271765e2e9f2d..4b8f0370b79bf 100644
> --- a/include/drm/drm_mode_config.h
> +++ b/include/drm/drm_mode_config.h
> @@ -532,8 +532,8 @@ struct drm_mode_config {
>   	 */
>   	struct list_head privobj_list;
>   
> -	int min_width, min_height;
> -	int max_width, max_height;
> +	unsigned int min_width, min_height;
> +	unsigned int max_width, max_height;

No problem, I just hope this has no fallout where these fields are being 
used.

Best regards
Thomas

>   	const struct drm_mode_config_funcs *funcs;
>   
>   	/* output poll support */

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)