linux-kernel - Re: [PATCH] bcachefs: replace deprecated strncpy() with strscpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <5F3AB2BC-43DA-47A6-A07A-72540B327D11@gmail.com>
Date: Wed, 26 Mar 2025 18:02:31 +0800
From: Alan Huang <mmpgouride@...il.com>
To: Roxana Nicolescu <nicolescu.roxana@...tonmail.com>
Cc: kent.overstreet@...ux.dev,
 linux-bcachefs@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 skhan@...uxfoundation.org,
 linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH] bcachefs: replace deprecated strncpy() with strscpy()

On Mar 26, 2025, at 17:44, Roxana Nicolescu <nicolescu.roxana@...tonmail.com> wrote:
> 
> strncpy() is deprecated for NUL-terminated destination buffers. Use
> strscpy() instead.
> 
> Link: https://github.com/KSPP/linux/issues/90
> Signed-off-by: Roxana Nicolescu <nicolescu.roxana@...tonmail.com>
> ---
> fs/bcachefs/btree_trans_commit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/bcachefs/btree_trans_commit.c b/fs/bcachefs/btree_trans_commit.c
> index c4f524b2ca9a..7ab25b425d11 100644
> --- a/fs/bcachefs/btree_trans_commit.c
> +++ b/fs/bcachefs/btree_trans_commit.c
> @@ -364,7 +364,7 @@ static noinline void journal_transaction_name(struct btree_trans *trans)
> struct jset_entry_log *l =
> container_of(entry, struct jset_entry_log, entry);
> 
> - strncpy(l->d, trans->fn, JSET_ENTRY_LOG_U64s * sizeof(u64));
> + strscpy(l->d, trans->fn, JSET_ENTRY_LOG_U64s * sizeof(u64));

The last time I asked Kent about this line, he didn’t want this.

> }
> 
> static inline int btree_key_can_insert(struct btree_trans *trans,
> -- 
> 2.34.1
> 
> 
>