linux-kernel - Re: [PATCH] PCI/MSI: Handle the NOMASK flag correctly for all PCI/MSI backends

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87frj0yn67.ffs@tglx>
Date: Wed, 26 Mar 2025 13:46:40 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Jürgen Groß <jgross@...e.com>, Roger Pau
 Monné <roger.pau@...rix.com>,
 Daniel Gomez <da.gomez@...nel.org>
Cc: Bjorn Helgaas <helgaas@...nel.org>, linux-kernel@...r.kernel.org,
 xen-devel@...ts.xenproject.org, linux-pci@...r.kernel.org, Bjorn Helgaas
 <bhelgaas@...gle.com>, Ingo Molnar <mingo@...hat.com>, Borislav Petkov
 <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
 "H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] PCI/MSI: Handle the NOMASK flag correctly for all
 PCI/MSI backends

On Wed, Mar 26 2025 at 13:09, Jürgen Groß wrote:
> On 26.03.25 13:05, Thomas Gleixner wrote:
>> The conversion of the XEN specific global variable pci_msi_ignore_mask to a
>> MSI domain flag, missed the facts that:
>> 
>>      1) Legacy architectures do not provide a interrupt domain
>>      2) Parent MSI domains do not necessarily have a domain info attached
>>     
>> Both cases result in an unconditional NULL pointer dereference.
>> 
>> Cure this by using the existing pci_msi_domain_supports() helper, which
>> handles all possible cases correctly.
>> 
>> Fixes: c3164d2e0d18 ("PCI/MSI: Convert pci_msi_ignore_mask to per MSI domain flag")
>> Reported-by: Daniel Gomez <da.gomez@...nel.org>
>> Reported-by: Borislav Petkov <bp@...en8.de>
>> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
>> Tested-by: Marek Szyprowski <m.szyprowski@...sung.com>
>> Tested-by: Borislav Petkov <bp@...en8.de>
>> Tested-by: Daniel Gomez <da.gomez@...nel.org>
>
> As the patch introducing the problem went in via the Xen tree, should
> this fix go in via the Xen tree, too?

I'll queue it up now and send Linus a pull request.