linux-kernel - Re: [PATCH 2/5] dt-bindings: net: Add MTIP L2 switch description (fec,mtip-switch.yaml)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aac75b30-d63e-4206-9173-231edeb69c05@kernel.org>
Date: Wed, 26 Mar 2025 15:15:14 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Lukasz Majewski <lukma@...x.de>, Andrew Lunn <andrew@...n.ch>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>, Paolo Abeni <pabeni@...hat.com>,
 Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>,
 davem@...emloft.net, Andrew Lunn <andrew+netdev@...n.ch>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, devicetree@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Richard Cochran <richardcochran@...il.com>,
 netdev@...r.kernel.org, Maxime Chevallier <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH 2/5] dt-bindings: net: Add MTIP L2 switch description
 (fec,mtip-switch.yaml)

On 26/03/2025 14:43, Lukasz Majewski wrote:
> Hi Andrew,
> 
>>> +  phy-reset-gpios:
>>> +    deprecated: true
>>> +    description:
>>> +      Should specify the gpio for phy reset.  
>>
>> It seem odd that a new binding has deprecated properties. Maybe add a
>> comment in the commit message as to why they are there. I assume this
>> is because you are re-using part of the FEC code as is, and it
>> implements them?
>>
> 
> In the case of MTIP L2 switch, the reset gpio line (in my case, but
> also on e.g. imx28-evk, and vf610) is single for both PHYs.

That's kind of proof that property was not placed in correct place.

> 
> I could move the reset to mdio child nodes, but this would be
> problematic, as asserting reset on one PHY would reset the second one.

It wouldn't if you used reset controller framework for that GPIO. Please
move the GPIOs to the device actually having the line, so the GPIOs.

Since a year such workarounds are not allowed in kernel anymore.

Best regards,
Krzysztof