linux-kernel - Re: [PATCH 1/1] i2c: imx: add some dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z+QN5jMuwj7S2L7J@lizhi-Precision-Tower-5810>
Date: Wed, 26 Mar 2025 10:23:34 -0400
From: Frank Li <Frank.li@....com>
To: Alexander Stein <alexander.stein@...tq-group.com>
Cc: Oleksij Rempel <o.rempel@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Andi Shyti <andi.shyti@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, linux-i2c@...r.kernel.org,
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] i2c: imx: add some dev_err_probe calls

On Wed, Mar 26, 2025 at 09:49:36AM +0100, Alexander Stein wrote:
> Especially DMA channels might not be available. Add some deferred probe
> messages accordingly.
>
> Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>
> ---

Reviewed-by: Frank Li <Frank.Li@....com>

>  drivers/i2c/busses/i2c-imx.c | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index 9e5d454d8318e..e6e09d5a2bbd4 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -1711,11 +1711,13 @@ static int i2c_imx_probe(struct platform_device *pdev)
>
>  	irq = platform_get_irq(pdev, 0);
>  	if (irq < 0)
> -		return irq;
> +		return dev_err_probe(&pdev->dev, irq,
> +				     "can't get IRQ\n");
>
>  	base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>  	if (IS_ERR(base))
> -		return PTR_ERR(base);
> +		return dev_err_probe(&pdev->dev, PTR_ERR(base),
> +				     "can't get IO memory\n");
>
>  	phy_addr = (dma_addr_t)res->start;
>  	i2c_imx = devm_kzalloc(&pdev->dev, sizeof(*i2c_imx), GFP_KERNEL);
> @@ -1810,13 +1812,15 @@ static int i2c_imx_probe(struct platform_device *pdev)
>  	 */
>  	ret = i2c_imx_dma_request(i2c_imx, phy_addr);
>  	if (ret) {
> -		if (ret == -EPROBE_DEFER)
> +		if (ret == -EPROBE_DEFER) {
> +			dev_err_probe(&pdev->dev, ret, "can't get DMA channels\n");
>  			goto clk_notifier_unregister;
> -		else if (ret == -ENODEV)
> +		} else if (ret == -ENODEV) {
>  			dev_dbg(&pdev->dev, "Only use PIO mode\n");
> -		else
> +		} else {
>  			dev_warn(&pdev->dev, "Failed to setup DMA (%pe), only use PIO mode\n",
>  				 ERR_PTR(ret));
> +		}
>  	}
>
>  	/* Add I2C adapter */
> --
> 2.43.0
>