linux-kernel - Re: [PATCH v3 03/11] mm/page_table_check: Batch-check pmds/puds just like ptes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+CK2bA3ctd6+G9DrJZ3RvnehPCrf7hEJ3boFJ5pkMTZyVmDSQ@mail.gmail.com>
Date: Wed, 26 Mar 2025 10:48:08 -0400
From: Pasha Tatashin <pasha.tatashin@...een.com>
To: Ryan Roberts <ryan.roberts@....com>
Cc: Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>, 
	Andrew Morton <akpm@...ux-foundation.org>, Uladzislau Rezki <urezki@...il.com>, 
	Christoph Hellwig <hch@...radead.org>, David Hildenbrand <david@...hat.com>, 
	"Matthew Wilcox (Oracle)" <willy@...radead.org>, Mark Rutland <mark.rutland@....com>, 
	Anshuman Khandual <anshuman.khandual@....com>, Alexandre Ghiti <alexghiti@...osinc.com>, 
	Kevin Brodsky <kevin.brodsky@....com>, linux-arm-kernel@...ts.infradead.org, 
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 03/11] mm/page_table_check: Batch-check pmds/puds just
 like ptes

> -void __page_table_check_pud_set(struct mm_struct *mm, pud_t *pudp, pud_t pud)
> +void __page_table_check_puds_set(struct mm_struct *mm, pud_t *pudp, pud_t pud,
> +               unsigned int nr)
>  {
> +       unsigned int i;
> +       unsigned long stride = PUD_SIZE >> PAGE_SHIFT;

nit: please order declarations from longest to shortest, it usually
helps with readability. (here and in pmd)

Reviewed-by: Pasha Tatashin <pasha.tatashin@...een.com>

Pasha