linux-kernel - Re: [PATCH v15 2/2] spi: spi-qpic: add driver for QCOM SPI NAND flash Interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <874izfrgn2.fsf@bootlin.com>
Date: Wed, 26 Mar 2025 15:49:37 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Md Sadre Alam <quic_mdalam@...cinc.com>,  broonie@...nel.org,
  robh@...nel.org,  krzk+dt@...nel.org,  conor+dt@...nel.org,
  richard@....at,  vigneshr@...com,  linux-arm-msm@...r.kernel.org,
  linux-spi@...r.kernel.org,  devicetree@...r.kernel.org,
  linux-kernel@...r.kernel.org,  linux-mtd@...ts.infradead.org
Subject: Re: [PATCH v15 2/2] spi: spi-qpic: add driver for QCOM SPI NAND
 flash Interface


>> Change in [v11]
>>
>> * Changed "depends on MTD" to "select MTD" in
>>   drivers/spi/Kconfig file
>
> Why? This is the only driver that selects MTD instead of depending on it.
>
>> Change in [v7]
>>
>> * Made CONFIG_SPI_QPIC_SNAND as bool
>
> Why? The driver uses MODULE_*, so a janitor may remove the latter.

Good catch, I agree on both comments.

Thanks,
Miquèl