linux-kernel - Re: [PATCH] ACPICA: Adjust the position of code lines.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gUDxrAn4W+Rf3ifjrg8Z9ZzTTOZjPFSSN5488mPqzXeA@mail.gmail.com>
Date: Wed, 26 Mar 2025 16:25:05 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Zhe Qiao <qiaozhe@...as.ac.cn>
Cc: robert.moore@...el.com, rafael.j.wysocki@...el.com, lenb@...nel.org, 
	linux-acpi@...r.kernel.org, acpica-devel@...ts.linux.dev, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPICA: Adjust the position of code lines.

On Thu, Mar 20, 2025 at 10:33 AM Zhe Qiao <qiaozhe@...as.ac.cn> wrote:
>
> In the acpica/utcache.c file, adjust the position of the
> "ACPI_MEM_TRACKING(cache->total_allocated++);" code line
> to ensure that the increment operation on total_allocated
> is included within the ACPI_DBG_TRACK_ALLOCATIONS configuration.
>
> Signed-off-by: Zhe Qiao <qiaozhe@...as.ac.cn>

In order to modify ACPICA code in the Linux kernel, please first
submit the change in question to the upstream ACPICA project on GitHub
as a pull request.  Once that pull request has been merged, you can
send a corresponding Linux patch with a Link: tag pointing to it, but
in principle it is not necessary to do so because ACPICA changes are
automatically integrated into the Linux code base on a more-or-less
regular basis.

Thanks!

> ---
>  drivers/acpi/acpica/utcache.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpica/utcache.c b/drivers/acpi/acpica/utcache.c
> index 85a85f7cf750..046e6ba127d4 100644
> --- a/drivers/acpi/acpica/utcache.c
> +++ b/drivers/acpi/acpica/utcache.c
> @@ -251,9 +251,9 @@ void *acpi_os_acquire_object(struct acpi_memory_list *cache)
>         } else {
>                 /* The cache is empty, create a new object */
>
> +#ifdef ACPI_DBG_TRACK_ALLOCATIONS
>                 ACPI_MEM_TRACKING(cache->total_allocated++);
>
> -#ifdef ACPI_DBG_TRACK_ALLOCATIONS
>                 if ((cache->total_allocated - cache->total_freed) >
>                     cache->max_occupied) {
>                         cache->max_occupied =
> --
> 2.34.1
>
>