linux-kernel - Re: [PATCH 3/3] iomap: rework IOMAP atomic flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8377df78-42fe-486c-acd9-3bcfbbc43cf3@oracle.com>
Date: Wed, 26 Mar 2025 15:50:42 +0000
From: John Garry <john.g.garry@...cle.com>
To: "Ritesh Harjani (IBM)" <ritesh.list@...il.com>,
        Christoph Hellwig <hch@....de>
Cc: brauner@...nel.org, djwong@...nel.org, linux-fsdevel@...r.kernel.org,
        dchinner@...hat.com, linux-xfs@...r.kernel.org,
        linux-kernel@...r.kernel.org, ojaswin@...ux.ibm.com,
        martin.petersen@...cle.com, tytso@....edu, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 3/3] iomap: rework IOMAP atomic flags

>>> So, I guess we can shift IOMAP_F_SIZE_CHANGED and IOMAP_F_STALE by
>>> 1 bit. So it will all look like..
>>
>> Let's create some more space to avoid this for the next round, e.g.
> 
> Sure, that make sense.
> 
>> count the core set flags from 31 down, and limit IOMAP_F_PRIVATE to a
>> single flag, which is how it is used.
> 
> flags in struct iomap is of type u16. So will make core iomap flags
> starting from bit 15, moving downwards.
> 
> Here is a diff of what I think you meant - let me know if this diff
> looks good to you?

This is still outstanding, and it would be nice to fix this ASAP.

How about we go to 32b and change IOMAP_F_PRIVATE for v6.16, while just 
fix as suggested originally (by renumbering) for v6.15?