linux-kernel - Re: [v3,net] net: phy: broadcom: Correct BCM5221 PHY model detection failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e367382f-2934-44f2-aba0-a8297d417548@broadcom.com>
Date: Wed, 26 Mar 2025 08:52:35 -0700
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Jim Liu <jim.t90615@...il.com>, JJLIU0@...oton.com, andrew@...n.ch,
 hkallweit1@...il.com, kuba@...nel.org, linux@...linux.org.uk,
 edumazet@...gle.com, pabeni@...hat.com
Cc: netdev@...r.kernel.org, giulio.benetti+tekvox@...ettiengineering.com,
 bcm-kernel-feedback-list@...adcom.com, linux-kernel@...r.kernel.org,
 Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
Subject: Re: [v3,net] net: phy: broadcom: Correct BCM5221 PHY model detection
 failure

On 3/25/25 02:10, Jim Liu wrote:
> Use "BRCM_PHY_MODEL" can be applied to the entire 5221 family of PHYs.
> 
> Fixes: 3abbd0699b67 ("net: phy: broadcom: add support for BCM5221 phy")
> Signed-off-by: Jim Liu <jim.t90615@...il.com>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> ---
> v3:
>     modify BRCM_PHY_MODEL define

Humm, I am not super confident in modifying BRCM_PHY_MODEL() since that 
impacts the entire driver, how about just using Russell's suggestion:

if (phydev->drv->phy_id == PHY_ID_BCM5221)

all over the place? That also paves the way for getting rid of 
BRCM_PHY_MODEL() once this patch is in net-next.

Thanks!
-- 
Florian