linux-kernel - Re: [PATCH] arm64/crc-t10dif: fix use of out-of-scope array in crc_t10dif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250327164106.GB1425@sol.localdomain>
Date: Thu, 27 Mar 2025 09:41:06 -0700
From: Eric Biggers <ebiggers@...nel.org>
To: David Binderman <dcb314@...mail.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
	Ard Biesheuvel <ardb@...nel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH] arm64/crc-t10dif: fix use of out-of-scope array in
 crc_t10dif_arch()

On Thu, Mar 27, 2025 at 07:58:51AM +0000, David Binderman wrote:
> Hello there Eric,
> 
> >Fix a silly bug where an array was used outside of its scope.
> 
> I am surprised your C compiler doesn't find this bug.
> gcc 14.2 onwards should be able to, but clang not.
> 
> I will make an enhancement request in clang.
> 
> Regards
> 
> David Binderman
> 

Neither gcc 14.2.0 nor clang 19.1.7 found it, unfortunately.  And the code still
passed crc_kunit (even when run with have_pmull disabled so that the code is
reached).

- Eric