linux-kernel - RE: [EXT] Re: [PATCH v4 1/2] wifi: mwifiex: Fix premature release of RF calibration data.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PAWPR04MB9910A3CC13C8B0F0674E3FA29CA12@PAWPR04MB9910.eurprd04.prod.outlook.com>
Date: Thu, 27 Mar 2025 17:26:51 +0000
From: Jeff Chen <jeff.chen_1@....com>
To: Brian Norris <briannorris@...omium.org>, Francesco Dolcini
	<francesco@...cini.it>
CC: "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"johannes@...solutions.net" <johannes@...solutions.net>, Pete Hsieh
	<tsung-hsien.hsieh@....com>, "s.hauer@...gutronix.de"
	<s.hauer@...gutronix.de>
Subject: RE: [EXT] Re: [PATCH v4 1/2] wifi: mwifiex: Fix premature release of
 RF calibration data.

> -----Original Message-----
> From: Brian Norris <briannorris@...omium.org>
> Sent: Wednesday, March 26, 2025 11:23 PM
> 
> On Wed, Mar 26, 2025 at 01:18:10PM +0100, Francesco Dolcini wrote:
> > On Tue, Mar 25, 2025 at 04:43:33PM +0000, Jeff Chen wrote:
> > > From: Francesco Dolcini <francesco@...cini.it>
> > > > On Tue, Mar 18, 2025 at 01:07:38PM +0800, Jeff Chen wrote:
> > > > > This patch resolves an issue where RF calibration data was being
> > > > > released before the download process. Without this fix, the
> > > > > external calibration data file would not be downloaded at all.
> > > > >
> > > > > Fixes: d39fbc88956e ("mwifiex: remove cfg_data construction")
> > > > > Signed-off-by: Jeff Chen <jeff.chen_1@....com>
> > > >
> > > > The code looks ok to me, however I do not understand the commit
> > > > you selected as fixes tag.
> > > >
> > > > From what I understand releasing the data before using it was done
> > > > since the initial commit 388ec385d5ce ("mwifiex: add calibration
> > > > data download feature"). What am I missing?
> > >
> > > Thank you for reviewing the patch. You are correct-the Fixes tag I included
> was incorrect.
> > > After re-examining the issue, I found that the premature release of
> > > RF calibration data cannot be reproduced, which invalidates the problem
> statement for this patch.
> > >
> > > I have decided to withdraw the patch. I appreciate your feedback and
> > > attention to detail, which helped identify this oversight.
> >
> > To me the code change is correct, and it is also merged in
> > wireless-next. No reason to drop it because of my comment on the fixes tag.
> >
> > Brian: are you ok with that?
> 
> Oh, sorry, I don't think I really analyzed the nature of the reasons for
> "withdrawal". Yes, if it's just the Fixes tag, then reverting isn't even that helpful.
> I'm fine with keeping it as-is.
> 
> Brian

Hi Johannes, Francesco, Brian, and all,
 
Thank you for your feedback and for bringing attention to this discussion. 
Moving forward, I will work on improving the process to avoid similar issues and
ensure better maintenance of the `mwifiex` driver.
Thank you for your understanding and support.

Best regards,  
Jeff