linux-kernel - Re: [PATCH] lib: scatterlist: Fix sg_split_phys to preserve original scatterlist offsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250327115043.fb46442c7e7fafc12295a8fd@linux-foundation.org>
Date: Thu, 27 Mar 2025 11:50:43 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: T Pratham <t-pratham@...com>
Cc: Jens Axboe <axboe@...nel.dk>, Robert Jarzmik <robert.jarzmik@...e.fr>,
 Kamlesh Gurudasani <kamlesh@...com>, Vignesh Raghavendra <vigneshr@...com>,
 Praneeth Bajjuri <praneeth@...com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] lib: scatterlist: Fix sg_split_phys to preserve
 original scatterlist offsets

On Wed, 26 Mar 2025 14:13:02 +0530 T Pratham <t-pratham@...com> wrote:

> >> Is this merely from code inspection, or is this issues known to have
> >> observable runtime effects?
> >>
> >> If the latter, please provide a complete description.
> > Hi,
> >
> > I am using this function in a crypto driver that I'm currently
> > developing (not yet sent to mailing list). During testing, it was
> > observed that the output scatterlists (except the first one) contained
> > incorrect garbage data.
> >
> > I narrowed this issue down to the call of sg_split(). Upon debugging
> > inside this function, I found that this resetting of offset is the cause
> > of the problem, causing the subsequent scatterlists to point to
> > incorrect memory locations in a page. By removing this code, I am
> > obtaining expected data in all the split output scatterlists. Thus, this
> > was indeed causing observable runtime effects!
> >
> > Regards
> > T Pratham <t-pratham@...com>
> 
> Hi Andrew,
> 
> Do you need the above details to be incorporated into the commit message
> and be resent? Kindly let me know.

I pasted it into the changelog.

I also added cc:stable, as this might be affecting other drivers,
whether in-tree or out-of-tree.