linux-kernel - Re: [PATCH v3 10/12] arm64: dts: imx8qm: add 24MHz clock-xtal24m

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250327190215.GC22659@pendragon.ideasonboard.com>
Date: Thu, 27 Mar 2025 21:02:15 +0200
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Frank Li <Frank.Li@....com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Dong Aisheng <aisheng.dong@....com>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Rui Miguel Silva <rmfrfs@...il.com>,
	Martin Kepplinger <martink@...teo.de>,
	Purism Kernel Team <kernel@...i.sm>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org,
	Robert Chiras <robert.chiras@....com>,
	"Guoniu.zhou" <guoniu.zhou@....com>
Subject: Re: [PATCH v3 10/12] arm64: dts: imx8qm: add 24MHz clock-xtal24m

On Thu, Mar 27, 2025 at 08:58:14PM +0200, Laurent Pinchart wrote:
> Hi Frank,
> 
> Thank you for the patch.
> 
> On Mon, Feb 10, 2025 at 03:59:29PM -0500, Frank Li wrote:
> > Add fixed clock node clock-xtal24m to prepare to add camera support.
> > 
> > Signed-off-by: Frank Li <Frank.Li@....com>
> > ---
> > change from v1 to v3
> > - none
> > ---
> >  arch/arm64/boot/dts/freescale/imx8qm.dtsi | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> > index c6a17a0d739c5..40cd45cd9f88f 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> > @@ -590,6 +590,13 @@ mipi_pll_div2_clk: clock-controller-mipi-div2-pll {
> >  		clock-output-names = "mipi_pll_div2_clk";
> >  	};
> >  
> > +	xtal24m: clock-xtal24m {
> > +		compatible = "fixed-clock";
> > +		#clock-cells = <0>;
> > +		clock-frequency = <24000000>;
> > +		clock-output-names = "xtal_24MHz";
> > +	};
> 
> This is a clock oscillator mounted on the PCB, isn't it ? It shouldn't
> be in imx8qm.dtsi, but in board-specific DT sources.

You add fixed regulators to arch/arm64/boot/dts/freescale/imx8qm-mek.dts
and arch/arm64/boot/dts/freescale/imx8qxp-mek.dts in patch 12/12, the
additional of the fixed clock could go there too, in the same patch.

> > +
> >  	vpu_subsys_dsp: bus@...00000 {
> >  		compatible = "simple-bus";
> >  		#address-cells = <1>;

-- 
Regards,

Laurent Pinchart