linux-kernel - Re: WARNING: modpost: vmlinux: section mismatch in reference: mm_cmdline_setup+0x94 (section: .text.unlikely) -> memblock (section: .init.data)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250327123624.bd59f1307d5c5b29b1b9ac08@linux-foundation.org>
Date: Thu, 27 Mar 2025 12:36:24 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Wei Yang <richard.weiyang@...il.com>
Cc: kernel test robot <lkp@...el.com>, Masahiro Yamada
 <masahiroy@...nel.org>, oe-kbuild-all@...ts.linux.dev,
 linux-kernel@...r.kernel.org, Linux Memory Management List
 <linux-mm@...ck.org>
Subject: Re: WARNING: modpost: vmlinux: section mismatch in reference:
 mm_cmdline_setup+0x94 (section: .text.unlikely) -> memblock (section:
 .init.data)

On Thu, 27 Mar 2025 01:13:12 +0000 Wei Yang <richard.weiyang@...il.com> wrote:

> Since it is only used by mmu_init() which is annotated by __init, I think the
> proper way is to add __init to mm_cmdline_setup.
> 
> 
> diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c
> index 4520c5741579..e98cfaf1c62b 100644
> --- a/arch/microblaze/mm/init.c
> +++ b/arch/microblaze/mm/init.c
> @@ -143,7 +143,7 @@ int page_is_ram(unsigned long pfn)
>  /*
>   * Check for command-line options that affect what MMU_init will do.
>   */
> -static void mm_cmdline_setup(void)
> +static void __init mm_cmdline_setup(void)
>  {
>  	unsigned long maxmem = 0;
>  	char *p = cmd_line;

That's a correct change anyway.  Please send along a patch sometime?