linux-kernel - Re: [PATCH] lib/sort.c: Add _nonatomic() variants with cond

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <novak4bihej44g63emwr6aohnnv3737ssbbbeldq2tqwmbf65n@j3fh7vsg77z5>
Date: Thu, 27 Mar 2025 15:47:13 -0400
From: Kent Overstreet <kent.overstreet@...ux.dev>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: linux-bcachefs@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Kuan-Wei Chiu <visitorckw@...il.com>
Subject: Re: [PATCH] lib/sort.c: Add _nonatomic() variants with cond_resched()

On Thu, Mar 27, 2025 at 11:09:23AM -0700, Andrew Morton wrote:
> On Wed, 26 Mar 2025 11:26:06 -0400 Kent Overstreet <kent.overstreet@...ux.dev> wrote:
> 
> > bcachefs calls sort() during recovery to sort all keys it found in the
> > journal, and this may be very large - gigabytes on large machines.
> > 
> > This has been causing "task blocked" warnings, so needs a
> > cond_resched().
> 
> I assume this has been happening for a while, so a cc:stable is appropriate?

Well, right now I'm only doing backports for the most critical stuff,
and this doesn't meet that bar. I'm planning on doing normal backports
after I take the experimental label off, in at most another year.

And I've told the stable team I don't want them touching fs/bcachefs/, I
want to be doing those backports and running them through my normal QA
process. We could for this, but perhaps better not to let the process
get confused :)