linux-kernel - Re: [PATCH v7 drm-dp 5/9] drm/hisilicon/hibmc: Getting connector info and EDID by using AUX channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a8599ca0-9a50-453e-8986-f8fae5aa9160@huawei.com>
Date: Thu, 27 Mar 2025 11:00:59 +0800
From: Yongbang Shi <shiyongbang@...wei.com>
To: Jani Nikula <jani.nikula@...ux.intel.com>, <xinliang.liu@...aro.org>,
	<tiantao6@...ilicon.com>, <maarten.lankhorst@...ux.intel.com>,
	<mripard@...nel.org>, <tzimmermann@...e.de>, <airlied@...il.com>,
	<daniel@...ll.ch>, <kong.kongxinwei@...ilicon.com>
CC: <liangjian010@...wei.com>, <chenjianmin@...wei.com>,
	<lidongming5@...wei.com>, <libaihan@...wei.com>, <shenjian15@...wei.com>,
	<shaojijie@...wei.com>, <dri-devel@...ts.freedesktop.org>,
	<linux-kernel@...r.kernel.org>, <shiyongbang@...wei.com>
Subject: Re: [PATCH v7 drm-dp 5/9] drm/hisilicon/hibmc: Getting connector info
 and EDID by using AUX channel


在 2025/3/26 17:32, Jani Nikula 写道:
> On Tue, 25 Mar 2025, Yongbang Shi <shiyongbang@...wei.com> wrote:
>>> On Mon, 24 Mar 2025, Yongbang Shi <shiyongbang@...wei.com> wrote:
>>>>> On Wed, 19 Mar 2025, Yongbang Shi <shiyongbang@...wei.com> wrote:
>>>>>> From: Baihan Li <libaihan@...wei.com>
>>>>>>
>>>>>> Add registering drm_aux and use it to get connector edid with drm
>>>>>> functions. Add ddc channel in connector initialization to put drm_aux
>>>>>> in drm_connector.
>>>>>>
>>>>>> Signed-off-by: Baihan Li <libaihan@...wei.com>
>>>>>> Signed-off-by: Yongbang Shi <shiyongbang@...wei.com>
>>>>>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
>>>>>> ---
>>>>>> ChangeLog:
>>>>>> v6 -> v7:
>>>>>>      - add if statement about drm aux in hibmc_dp_connector_get_modes(), suggested by Jani Nikula
>>>>> I don't understand this, and I did not suggest such a thing.
>>>>>
>>>>> BR,
>>>>> Jani.
>>>>>
>>>> Hi Jani,
>>>>
>>>> Is the modification of v8 correct?
>>> I never received that for whatever reason.
>> Here's the link: https://lore.kernel.org/all/20250320101455.2538835-1-shiyongbang@huawei.com/
> Thanks.
>
> The EDID handling looks fine.
>
> AFAICT you leak dp->aux.name though.
>
>
> BR,
> Jani.

Thanks for for reminding me, actually the dp->aux.name was written because I misunderstood what you meant in V7,
and I deleted it in V8.

Thanks,
Baihan.

>
>