linux-kernel - Re: [PATCH v3 04/12] media: nxp: imx8-isi: Allow num_sources to be greater than num

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHCN7x+6_xxkx-Fft6WnfsVyqy_v3c732uKuEanrP64jv3Kj1g@mail.gmail.com>
Date: Thu, 27 Mar 2025 15:02:29 -0500
From: Adam Ford <aford173@...il.com>
To: Frank Li <Frank.Li@....com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Dong Aisheng <aisheng.dong@....com>, 
	Philipp Zabel <p.zabel@...gutronix.de>, Shawn Guo <shawnguo@...nel.org>, 
	Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>, 
	Fabio Estevam <festevam@...il.com>, Laurent Pinchart <laurent.pinchart@...asonboard.com>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, Rui Miguel Silva <rmfrfs@...il.com>, 
	Martin Kepplinger <martink@...teo.de>, Purism Kernel Team <kernel@...i.sm>, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, imx@...ts.linux.dev, 
	linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org, 
	Robert Chiras <robert.chiras@....com>, "Guoniu.zhou" <guoniu.zhou@....com>
Subject: Re: [PATCH v3 04/12] media: nxp: imx8-isi: Allow num_sources to be
 greater than num_sink

On Mon, Feb 10, 2025 at 3:01 PM Frank Li <Frank.Li@....com> wrote:
>
> Allow num_sources (drvdata: num_channels) to be greater than num_sink
> (drvdata: num_ports + 1).
>
> ISI support stream multiplexing, such as differentiates multiple cameras
> from a single 2-lane MIPI input, or duplicates input stream into multiple
> outputs. So num_channels may be greater than num_ports at some platform.

Can you tell me which platforms support this?   Is this through
virtual channels, or do you physically connect lanes 1 and 2 to one
camera and lanes 3 and 4 to another?

adam
>
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
> change from v1 to v3
> - none
> ---
>  drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
> index 93a55c97cd173..ba5b2d3617a23 100644
> --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
> +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
> @@ -188,11 +188,11 @@ static int mxc_isi_crossbar_init_state(struct v4l2_subdev *sd,
>          * Create a 1:1 mapping between pixel link inputs and outputs to
>          * pipelines by default.
>          */
> -       routes = kcalloc(xbar->num_sources, sizeof(*routes), GFP_KERNEL);
> +       routes = kcalloc(xbar->num_sinks - 1, sizeof(*routes), GFP_KERNEL);
>         if (!routes)
>                 return -ENOMEM;
>
> -       for (i = 0; i < xbar->num_sources; ++i) {
> +       for (i = 0; i < xbar->num_sinks - 1; ++i) {
>                 struct v4l2_subdev_route *route = &routes[i];
>
>                 route->sink_pad = i;
> @@ -200,7 +200,7 @@ static int mxc_isi_crossbar_init_state(struct v4l2_subdev *sd,
>                 route->flags = V4L2_SUBDEV_ROUTE_FL_ACTIVE;
>         }
>
> -       routing.num_routes = xbar->num_sources;
> +       routing.num_routes = xbar->num_sinks - 1;
>         routing.routes = routes;
>
>         ret = __mxc_isi_crossbar_set_routing(sd, state, &routing);
> @@ -453,7 +453,7 @@ int mxc_isi_crossbar_init(struct mxc_isi_dev *isi)
>          * the memory input.
>          */
>         xbar->num_sinks = isi->pdata->num_ports + 1;
> -       xbar->num_sources = isi->pdata->num_ports;
> +       xbar->num_sources = isi->pdata->num_channels;
>         num_pads = xbar->num_sinks + xbar->num_sources;
>
>         xbar->pads = kcalloc(num_pads, sizeof(*xbar->pads), GFP_KERNEL);
>
> --
> 2.34.1
>
>