linux-kernel - Re: [PATCH] spi: fsl-qspi: use devm function instead of driver remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <174310991931.446685.5350029703728855284.b4-ty@kernel.org>
Date: Thu, 27 Mar 2025 21:11:59 +0000
From: Mark Brown <broonie@...nel.org>
To: John Ogness <john.ogness@...utronix.de>, 
 Volker Haspel <volker.haspel@...utronix.de>, Han Xu <han.xu@....com>
Cc: stable@...r.kernel.org, Kevin Hao <haokexin@...il.com>, 
 linux-spi@...r.kernel.org, imx@...ts.linux.dev, 
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: fsl-qspi: use devm function instead of driver
 remove

On Wed, 26 Mar 2025 17:41:51 -0500, Han Xu wrote:
> Driver use devm APIs to manage clk/irq/resources and register the spi
> controller, but the legacy remove function will be called first during
> device detach and trigger kernel panic. Drop the remove function and use
> devm_add_action_or_reset() for driver cleanup to ensure the release
> sequence.
> 
> Trigger kernel panic on i.MX8MQ by
> echo 30bb0000.spi >/sys/bus/platform/drivers/fsl-quadspi/unbind
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: fsl-qspi: use devm function instead of driver remove
      commit: 40369bfe717e96e26650eeecfa5a6363563df6e4

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark