linux-kernel - Re: [PATCH] input: atkbd: do not init atkbd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAhV-H785p1cc+_22HYMBqinv4B-tfYCO7i4VwyR2ki9fx4Oiw@mail.gmail.com>
Date: Thu, 27 Mar 2025 12:10:00 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Qunqin Zhao <zhaoqunqin@...ngson.cn>
Cc: dmitry.torokhov@...il.com, linux-input@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] input: atkbd: do not init atkbd_reset variable to true on Loongson

Hi, Qunqin,

On Thu, Mar 27, 2025 at 10:58 AM Qunqin Zhao <zhaoqunqin@...ngson.cn> wrote:
>
> The keyboard will not be confused on Loongson platform, so do not need a
> full reset of the keyboard.
>
> Signed-off-by: Qunqin Zhao <zhaoqunqin@...ngson.cn>
> ---
>  drivers/input/keyboard/atkbd.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
> index adf0f31199..f8ef3e929a 100644
> --- a/drivers/input/keyboard/atkbd.c
> +++ b/drivers/input/keyboard/atkbd.c
> @@ -37,7 +37,8 @@ static int atkbd_set = 2;
>  module_param_named(set, atkbd_set, int, 0);
>  MODULE_PARM_DESC(set, "Select keyboard code set (2 = default, 3 = PS/2 native)");
>
> -#if defined(__i386__) || defined(__x86_64__) || defined(__hppa__)
> +#if defined(__i386__) || defined(__x86_64__) || defined(__hppa__) ||   \
> +       defined(__loongarch__)
No new line is needed, now there is no 80 columns limit.
Reviewed-by: Huacai Chen <chenhuacai@...ngson.cn>


Huacai

>  static bool atkbd_reset;
>  #else
>  static bool atkbd_reset = true;
> --
> 2.45.2
>