linux-kernel - Re: [PATCH 1/6] media: ti: j721e-csi2rx: Use devm_of_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b7439746-4143-4504-939e-e8abd705c962@ti.com>
Date: Thu, 27 Mar 2025 11:55:30 +0530
From: Devarsh Thakkar <devarsht@...com>
To: Jai Luthra <jai.luthra@...asonboard.com>,
        Jai Luthra
	<jai.luthra@...ux.dev>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Hans
 Verkuil <hverkuil@...all.nl>,
        Tomi Valkeinen
	<tomi.valkeinen@...asonboard.com>,
        Sakari Ailus
	<sakari.ailus@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>
CC: Rishikesh Donadkar <r-donadkar@...com>,
        Vaishnav Achath
	<vaishnav.a@...com>,
        Changhuang Liang <changhuang.liang@...rfivetech.com>,
        <linux-media@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <stable@...r.kernel.org>
Subject: Re: [PATCH 1/6] media: ti: j721e-csi2rx: Use
 devm_of_platform_populate

On 24/03/25 17:31, Jai Luthra wrote:
> Ensure that we clean up the platform bus when we remove this driver.
> 
> This fixes a crash seen when reloading the module for the child device
> with the parent not yet reloaded.
> 
> Fixes: b4a3d877dc92 ("media: ti: Add CSI2RX support for J721E")
> Cc: stable@...r.kernel.org
> Signed-off-by: Jai Luthra <jai.luthra@...asonboard.com>

Reviewed-by: Devarsh Thakkar <devarsht@...com>

Regards
Devarsh
> ---
>   drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c b/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
> index 6412a00be8eab89548950dd21b3b3ec02dafa5b4..a066024bf745450e2ba01d06c0fec4e6bdbfa97e 100644
> --- a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
> +++ b/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
> @@ -1118,7 +1118,7 @@ static int ti_csi2rx_probe(struct platform_device *pdev)
>   	if (ret)
>   		goto err_vb2q;
>   
> -	ret = of_platform_populate(csi->dev->of_node, NULL, NULL, csi->dev);
> +	ret = devm_of_platform_populate(csi->dev);
>   	if (ret) {
>   		dev_err(csi->dev, "Failed to create children: %d\n", ret);
>   		goto err_subdev;
>