linux-kernel - Re: [PATCH] arm64/crc-t10dif: fix use of out-of-scope array in crc_t10dif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMj1kXHCJQ4-KAPpWFA-rqjogbebUP8Y=NKrdEB1ZmSbKG3bdg@mail.gmail.com>
Date: Thu, 27 Mar 2025 09:15:09 +0100
From: Ard Biesheuvel <ardb@...nel.org>
To: Eric Biggers <ebiggers@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	stable@...r.kernel.org, David Binderman <dcb314@...mail.com>
Subject: Re: [PATCH] arm64/crc-t10dif: fix use of out-of-scope array in crc_t10dif_arch()

On Wed, 26 Mar 2025 at 21:09, Eric Biggers <ebiggers@...nel.org> wrote:
>
> From: Eric Biggers <ebiggers@...gle.com>
>
> Fix a silly bug where an array was used outside of its scope.
>

Yeah - mea culpa.

And the fact that we exit with a tail call means buf[] may be
deallocated by the time crc_t10dif_generic() refers to it - I'm
surprised this didn't already break in testing, but I suppose no tail
call is issued for other reasons.