linux-kernel - Re: [PATCH 0/10] More Rust bindings for device property reads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z-UPcB6vnwBUs3FP@smile.fi.intel.com>
Date: Thu, 27 Mar 2025 10:42:24 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Andrew Ballance <andrewjballance@...il.com>
Cc: remo@...nzli.dev, a.hindborg@...nel.org, alex.gaynor@...il.com,
	aliceryhl@...gle.com, benno.lossin@...ton.me,
	bjorn3_gh@...tonmail.com, boqun.feng@...il.com, dakr@...nel.org,
	devicetree@...r.kernel.org, dirk.behme@...bosch.com,
	djrscally@...il.com, gary@...yguo.net, gregkh@...uxfoundation.org,
	heikki.krogerus@...ux.intel.com, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, ojeda@...nel.org, rafael@...nel.org,
	robh@...nel.org, rust-for-linux@...r.kernel.org,
	sakari.ailus@...ux.intel.com, saravanak@...gle.com,
	tmgross@...ch.edu
Subject: Re: [PATCH 0/10] More Rust bindings for device property reads

On Wed, Mar 26, 2025 at 03:54:09PM -0500, Andrew Ballance wrote:
> Hi thanks for sending these in.
> 
> On Wed, Mar 26, 2025 at 12:13 PM Remo Senekowitsch Wrote: 
> > This is my first time posting to the mailing list, please let me know if
> > I did anything wrong.
> 
> you probably will have to resubmit in the patch canonical format[1]
> 
> I would recomend reading the docs but in summary:
>  - all of your patches should have the subsystem in the subject line.
>  - patch 6 is missing a commit message
>  - commit messages should be written in the imperitive tone
>  - a couple of your commit messages give a reason for the changes but
>    do not have a summary of the changes

>  - for your v2 you should add a diffstat to your cover letter running
>    `git format-patch --base=auto --cover-letter` does this automatically
>    for you

Also -v<X> gives the proper versioning.

> [1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format

-- 
With Best Regards,
Andy Shevchenko