linux-kernel - Re: [PATCH v3] ktest: Fix Test Failures Due to Missing LOG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1a7c98a-9aeb-4e58-8d8f-d4e5c0e305d4@amd.com>
Date: Thu, 27 Mar 2025 15:46:37 +0530
From: "Jain, Ayush" <ayushjai@....com>
To: Ayush Jain <Ayush.jain3@....com>, rostedt@...dmis.org,
 warthog9@...lescrag.net
Cc: linux-kernel@...r.kernel.org, srikanth.aithal@....com,
 kalpana.shetty@....com
Subject: Re: [PATCH v3] ktest: Fix Test Failures Due to Missing LOG_FILE
 Directories

Hello Steven,

Hope you're doing well! Just a quick follow-up on this,
would appreciate your feedback when you get a chance. Let me know if you
need anything from me.

TiA,
Ayush

On 3/7/2025 10:08 AM, Ayush Jain wrote:
> Handle missing parent directories for LOG_FILE path to prevent test
> failures. If the parent directories don't exist, create them to ensure
> the tests proceed successfully.
>
> Signed-off-by: Ayush Jain <Ayush.jain3@....com>
> ---
>  tools/testing/ktest/ktest.pl | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl
> index 8c8da966c641..a5f7fdd0c1fb 100755
> --- a/tools/testing/ktest/ktest.pl
> +++ b/tools/testing/ktest/ktest.pl
> @@ -4303,6 +4303,14 @@ if (defined($opt{"LOG_FILE"})) {
>      if ($opt{"CLEAR_LOG"}) {
>  	unlink $opt{"LOG_FILE"};
>      }
> +
> +    if (! -e $opt{"LOG_FILE"} && $opt{"LOG_FILE"} =~ m,^(.*/),) {
> +        my $dir = $1;
> +        if (! -d $dir) {
> +            mkpath($dir) or die "Failed to create directories '$dir': $!";
> +            print "\nThe log directory $dir did not exist, so it was created.\n";
> +        }
> +    }
>      open(LOG, ">> $opt{LOG_FILE}") or die "Can't write to $opt{LOG_FILE}";
>      LOG->autoflush(1);
>  }