linux-kernel - Re: [PATCH v3] mm/page_alloc: Simplify free_page_is_bad by removing free_page_is_bad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z-UvTBZqGdufLfwu@localhost.localdomain>
Date: Thu, 27 Mar 2025 11:58:20 +0100
From: Oscar Salvador <osalvador@...e.de>
To: Ye Liu <ye.liu@...ux.dev>
Cc: akpm@...ux-foundation.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, anshuman.khandual@....com,
	Ye Liu <liuye@...inos.cn>
Subject: Re: [PATCH v3] mm/page_alloc: Simplify free_page_is_bad by removing
 free_page_is_bad_report

On Wed, Mar 26, 2025 at 09:24:34AM +0800, Ye Liu wrote:
> From: Ye Liu <liuye@...inos.cn>
> 
> Refactors the free_page_is_bad function by directly calling bad_page() 
> instead of using the intermediary function free_page_is_bad_report(). 
> The removal of free_page_is_bad_report() reduces unnecessary indirection,
> making the code cleaner and easier to read.
> 
> The functionality remains the same, as free_page_is_bad_report() was
> merely a wrapper for the bad_page() call. The patch also improves
> maintainability by reducing the function call depth.

I would trim this down.

> 
> Signed-off-by: Ye Liu <liuye@...inos.cn>
> Reviewed-by: Anshuman Khandual <anshuman.khandual@....com>

Reviewed-by: Oscar Salvador <osalvador@...e.de>


-- 
Oscar Salvador
SUSE Labs