linux-kernel - Re: [PATCH V2 2/2] regulator: s5m8767: Convert to GPIO descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z-U4bAMt82SipwuY@smile.fi.intel.com>
Date: Thu, 27 Mar 2025 13:37:16 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: "Peng Fan (OSS)" <peng.fan@....nxp.com>
Cc: linus.walleij@...aro.org, brgl@...ev.pl, krzk@...nel.org,
	lgirdwood@...il.com, broonie@...nel.org, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
	Peng Fan <peng.fan@....com>
Subject: Re: [PATCH V2 2/2] regulator: s5m8767: Convert to GPIO descriptors

On Thu, Mar 27, 2025 at 08:49:45AM +0800, Peng Fan (OSS) wrote:

> Update the driver to fetch buck_gpio and buck_ds as GPIO descriptors.
> Then drop the usage of 'of_gpio.h' which should be deprecated.
> Based on commit 84618d5e31cf ("regulator: max8997:
> Convert to GPIO descriptors") as a reference to make the changes.
> 
> With the quirk fix for s5m8767 in of_gpio_try_fixup_polarity,
> the polarity will be active-high, even if exynos5250 spring DTS
> wrongly use active-low polarity. So using GPIO descriptors,
> it should work as before.

I was a bit trapped by the set_low and set_high callback implementation,
but I think I understood the idea behind and this code does not change
the original logic.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

-- 
With Best Regards,
Andy Shevchenko