linux-kernel - Re: [PATCH 0/2] PCI: Remove pcim_iounmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z-U5vIbVDZLe9QnM@smile.fi.intel.com>
Date: Thu, 27 Mar 2025 13:42:52 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Philipp Stanner <phasta@...nel.org>
Cc: Jonathan Corbet <corbet@....net>, Jens Axboe <axboe@...nel.dk>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Mark Brown <broonie@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Philipp Stanner <pstanner@...hat.com>,
	Damien Le Moal <dlemoal@...nel.org>,
	Yang Yingliang <yangyingliang@...wei.com>,
	Zijun Hu <quic_zijuhu@...cinc.com>, Hannes Reinecke <hare@...e.de>,
	Al Viro <viro@...iv.linux.org.uk>, Li Zetao <lizetao1@...wei.com>,
	Anuj Gupta <anuj20.g@...sung.com>, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH 0/2] PCI: Remove pcim_iounmap_regions()

On Thu, Mar 27, 2025 at 12:07:06PM +0100, Philipp Stanner wrote:
> The last remaining user of pcim_iounmap_regions() is mtip32 (in Linus's
> current master)
> 
> So we could finally remove this deprecated API. I suggest that this gets
> merged through the PCI tree.

Good god! One API less, +1 to support this move.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

> (I also suggest we watch with an eagle's
> eyes for folks who want to re-add calls to that function before the next
> merge window opens).

Instead of this I suggest that PCI can take this before merge window finishes
and cooks the (second) PR with it. In such a case we wouldn't need to care,
the developers will got broken builds.

-- 
With Best Regards,
Andy Shevchenko