linux-kernel - Re: [Intel-wired-lan] [PATCH iwl-next] igc: enable HW vlan tag insertion/stripping by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2710245b-5c2d-4c1f-93ef-937788c3c21b@intel.com>
Date: Thu, 27 Mar 2025 14:53:46 +0200
From: Mor Bar-Gabay <morx.bar.gabay@...el.com>
To: Rui Salvaterra <rsalvaterra@...il.com>, <anthony.l.nguyen@...el.com>,
	<przemyslaw.kitszel@...el.com>
CC: <edumazet@...gle.com>, <kuba@...nel.org>,
	<intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next] igc: enable HW vlan tag
 insertion/stripping by default

On 13/03/2025 11:35, Rui Salvaterra wrote:
> This is enabled by default in other Intel drivers I've checked (e1000, e1000e,
> iavf, igb and ice). Fixes an out-of-the-box performance issue when running
> OpenWrt on typical mini-PCs with igc-supported Ethernet controllers and 802.1Q
> VLAN configurations, as ethtool isn't part of the default packages and sane
> defaults are expected.
> 
> In my specific case, with an Intel N100-based machine with four I226-V Ethernet
> controllers, my upload performance increased from under 30 Mb/s to the expected
> ~1 Gb/s.
> 
> Signed-off-by: Rui Salvaterra <rsalvaterra@...il.com>
> Reviewed-by: Simon Horman <horms@...nel.org>
> Reviewed-by: Vitaly Lifshits <vitaly.lifshits@...el.com>
> Reviewed-by: Kurt Kanzenbach <kurt@...utronix.de>
> ---
>   drivers/net/ethernet/intel/igc/igc_main.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
Tested-by: Mor Bar-Gabay <morx.bar.gabay@...el.com>