linux-kernel - Re: [Intel-wired-lan] [PATCH iwl-next v10 08/14] igc: use FIELD_PREP and GENMASK for existing RX packet buffer size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6e1ee185-c7e0-4539-b8fb-fa6cb02571a6@intel.com>
Date: Thu, 27 Mar 2025 14:59:37 +0200
From: Mor Bar-Gabay <morx.bar.gabay@...el.com>
To: Faizal Rahim <faizal.abdul.rahim@...ux.intel.com>, Tony Nguyen
	<anthony.l.nguyen@...el.com>, Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, "David S . Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Maxime Coquelin
	<mcoquelin.stm32@...il.com>, Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Simon Horman <horms@...nel.org>, Vladimir Oltean <vladimir.oltean@....com>,
	Russell King <linux@...linux.org.uk>, Alexei Starovoitov <ast@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>, Jesper Dangaard Brouer
	<hawk@...nel.org>, John Fastabend <john.fastabend@...il.com>, Furong Xu
	<0x1207@...il.com>, Choong Yong Liang <yong.liang.choong@...ux.intel.com>,
	Russell King <rmk+kernel@...linux.org.uk>, Hariprasad Kelam
	<hkelam@...vell.com>, Xiaolei Wang <xiaolei.wang@...driver.com>, "Suraj
 Jaiswal" <quic_jsuraj@...cinc.com>, Kory Maincent
	<kory.maincent@...tlin.com>, Gal Pressman <gal@...dia.com>, Jesper Nilsson
	<jesper.nilsson@...s.com>, <linux-arm-kernel@...ts.infradead.org>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<bpf@...r.kernel.org>, <intel-wired-lan@...ts.osuosl.org>,
	<linux-stm32@...md-mailman.stormreply.com>, Chwee-Lin Choong
	<chwee.lin.choong@...el.com>, Vinicius Costa Gomes
	<vinicius.gomes@...el.com>, Kunihiko Hayashi
	<hayashi.kunihiko@...ionext.com>, Serge Semin <fancer.lancer@...il.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v10 08/14] igc: use FIELD_PREP
 and GENMASK for existing RX packet buffer size

On 18/03/2025 5:07, Faizal Rahim wrote:
> Prepare for an upcoming patch that modifies the RX buffer size in TSN mode.
> Refactor IGC_RXPBSIZE_EXP_BMC_DEFAULT and IGC_RXPBS_CFG_TS_EN using
> FIELD_PREP and GENMASK to improve clarity and maintainability. Refactor
> both macros for consistency, even though the upcoming patch only use
> IGC_RXPBSIZE_EXP_BMC_DEFAULT.
> 
> The newly introduced macros follow the naming from the i226 SW User Manual
> for easy reference.
> 
> I've tested IGC_RXPBSIZE_EXP_BMC_DEFAULT and IGC_RXPBS_CFG_TS_EN before
> and after the refactoring, and their values remain unchanged.
> 
> Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>
> Signed-off-by: Faizal Rahim <faizal.abdul.rahim@...ux.intel.com>
> ---
>   drivers/net/ethernet/intel/igc/igc_defines.h | 17 ++++++++++++++---
>   1 file changed, 14 insertions(+), 3 deletions(-)
> 
Tested-by: Mor Bar-Gabay <morx.bar.gabay@...el.com>