linux-kernel - Re: [Intel-wired-lan] [PATCH iwl-next v10 14/14] igc: add support to get frame preemption statistics via ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fee7bc17-5972-41e2-8656-08edd45c040c@intel.com>
Date: Thu, 27 Mar 2025 15:05:53 +0200
From: Mor Bar-Gabay <morx.bar.gabay@...el.com>
To: Faizal Rahim <faizal.abdul.rahim@...ux.intel.com>, Tony Nguyen
	<anthony.l.nguyen@...el.com>, Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, "David S . Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Maxime Coquelin
	<mcoquelin.stm32@...il.com>, Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Simon Horman <horms@...nel.org>, Vladimir Oltean <vladimir.oltean@....com>,
	Russell King <linux@...linux.org.uk>, Alexei Starovoitov <ast@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>, Jesper Dangaard Brouer
	<hawk@...nel.org>, John Fastabend <john.fastabend@...il.com>, Furong Xu
	<0x1207@...il.com>, Choong Yong Liang <yong.liang.choong@...ux.intel.com>,
	Russell King <rmk+kernel@...linux.org.uk>, Hariprasad Kelam
	<hkelam@...vell.com>, Xiaolei Wang <xiaolei.wang@...driver.com>, "Suraj
 Jaiswal" <quic_jsuraj@...cinc.com>, Kory Maincent
	<kory.maincent@...tlin.com>, Gal Pressman <gal@...dia.com>, Jesper Nilsson
	<jesper.nilsson@...s.com>, <linux-arm-kernel@...ts.infradead.org>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<bpf@...r.kernel.org>, <intel-wired-lan@...ts.osuosl.org>,
	<linux-stm32@...md-mailman.stormreply.com>, Chwee-Lin Choong
	<chwee.lin.choong@...el.com>, Vinicius Costa Gomes
	<vinicius.gomes@...el.com>, Kunihiko Hayashi
	<hayashi.kunihiko@...ionext.com>, Serge Semin <fancer.lancer@...il.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v10 14/14] igc: add support to
 get frame preemption statistics via ethtool

On 18/03/2025 5:07, Faizal Rahim wrote:
> Implemented "ethtool --include-statistics --show-mm" callback for IGC.
> 
> Tested preemption scenario to check preemption statistics:
> 1) Trigger verification handshake on both boards:
>      $ sudo ethtool --set-mm enp1s0 pmac-enabled on
>      $ sudo ethtool --set-mm enp1s0 tx-enabled on
>      $ sudo ethtool --set-mm enp1s0 verify-enabled on
> 2) Set preemptible or express queue in taprio for tx board:
>      $ sudo tc qdisc replace dev enp1s0 parent root handle 100 taprio \
>        num_tc 4 map 3 2 1 0 3 3 3 3 3 3 3 3 3 3 3 3 \
>        queues 1@0 1@1 1@2 1@3 base-time 0 sched-entry S F 100000 \
>        fp E E P P
> 3) Send large size packets on preemptible queue
> 4) Send small size packets on express queue to preempt packets in
>     preemptible queue
> 5) Show preemption statistics on the receiving board:
>     $ ethtool --include-statistics --show-mm enp1s0
>       MAC Merge layer state for enp1s0:
>       pMAC enabled: on
>       TX enabled: on
>       TX active: on
>       TX minimum fragment size: 64
>       RX minimum fragment size: 60
>       Verify enabled: on
>       Verify time: 128
>       Max verify time: 128
>       Verification status: SUCCEEDED
>       Statistics:
>        MACMergeFrameAssErrorCount: 0
>        MACMergeFrameSmdErrorCount: 0
>        MACMergeFrameAssOkCount: 511
>        MACMergeFragCountRx: 764
>        MACMergeFragCountTx: 0
>        MACMergeHoldCount: 0
> 
> Co-developed-by: Vinicius Costa Gomes <vinicius.gomes@...el.com>
> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@...el.com>
> Co-developed-by: Chwee-Lin Choong <chwee.lin.choong@...el.com>
> Signed-off-by: Chwee-Lin Choong <chwee.lin.choong@...el.com>
> Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>
> Signed-off-by: Faizal Rahim <faizal.abdul.rahim@...ux.intel.com>
> ---
>   drivers/net/ethernet/intel/igc/igc_ethtool.c | 40 ++++++++++++++++++++
>   drivers/net/ethernet/intel/igc/igc_regs.h    | 16 ++++++++
>   2 files changed, 56 insertions(+)
> 
Tested-by: Mor Bar-Gabay <morx.bar.gabay@...el.com>