linux-kernel - Re: [PATCH] PCI: Add MUCSE vendor ID to pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250327133757.GA1432088@bhelgaas>
Date: Thu, 27 Mar 2025 08:37:57 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Yibo Dong <dong100@...se.com>
Cc: bhelgaas@...gle.com, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: Add MUCSE vendor ID to pci_ids.h

On Thu, Mar 27, 2025 at 07:24:26PM +0800, Yibo Dong wrote:
> On Wed, Mar 26, 2025 at 11:57:28AM -0500, Bjorn Helgaas wrote:
> > On Tue, Mar 25, 2025 at 02:57:18PM +0800, Yibo Dong wrote:
> > > Add MUCSE as a vendor ID (0x8848) for PCI devices so we can use
> > > the macro for future drivers.
> > > 
> > > Signed-off-by: Yibo Dong <dong100@...se.com>
> > 
> > Please post this in the series where you add the future drivers.
> > 
> > We don't add new things to pci_ids.h unless they are actually used by
> > more than one driver because it complicates life for people who
> > backport things (there's a note at the top of the file about this).
> 
> Thanks for the reminder; the drivers maybe use 'the define' are
> netdev drivers, so, I should first send patches to netdev subsystem,
> and re-send this patch to pci subsystem after my patches is applied
> by netdev subsytem? or I should send this to netdev subsystem along
> with the drivers?

Just include it with your netdev series and cc me.  I'll ack it and
the whole series can be merged together via netdev.

> > > +#define PCI_VENDOR_ID_MUCSE		0x8848
> > 
> > https://pcisig.com/membership/member-companies?combine=8848 says this
> > Vendor ID belongs to:
> > 
> >   Wuxi Micro Innovation Integrated Circuit Design Co.,Ltd
> > 
> > I suppose "MUCSE" connects with that somehow.
> > 
> > It's nice if people can connect PCI_VENDOR_ID_MUCSE with a name used
> > in marketing the product.  Maybe "MUCSE" is the name under which
> > Wuxi Micro Innovation Integrated Circuit Design Co.,Ltd markets
> > products?
> 
> Yes, MUCSE is just abbreviation for “Wuxi Micro Innovation Integrated Circuit
> Design Co.,Ltd”

Perfect.  I see you've already added it to the lspci database along
with several devices:

  https://admin.pci-ids.ucw.cz/read/PC/8848

All looks good!  I'll watch for your netdev patches.

Bjorn