linux-kernel - Re: [PATCH V1] spi: Add support for Double Transfer Rate (DTR) mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f3115251-8fa9-4019-8fb0-145daf32cfa2@sirena.org.uk>
Date: Thu, 27 Mar 2025 14:07:04 +0000
From: Mark Brown <broonie@...nel.org>
To: Mukesh Kumar Savaliya <quic_msavaliy@...cinc.com>
Cc: linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
	andersson@...nel.org, konradybcio@...nel.org
Subject: Re: [PATCH V1] spi: Add support for Double Transfer Rate (DTR) mode

On Thu, Mar 27, 2025 at 03:33:15PM +0530, Mukesh Kumar Savaliya wrote:

> IIUC, It comes to the point of first identifying if it's in context of QSPI
> controller or SPI controller right ?

> Identify if SPI/QSPI controller has this capability using dtr_caps =
> true/false. Then check if it's supporting SDR/DDR mode. Can we then
> introduce below struct to first mark capability as true/false and then
> process dtr_mode ?

> if not supported (dtr_caps = false), then don't care dtr_mode.

We should complain if the device requsted anything the controller can't
support.

> struct spi_caps {
> 	bool dtr_mode;
> 	bool dtr_caps;
> };

The controller capabilities are currently mainly advertised via the
SPI_CONTROLLER_ flags but adding some bools also works, some things
already do use that.  I'm not sure we need to wrap things in a further
struct though.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)