linux-kernel - Re: [PATCH] arm64: dts: imx8mp: Add device tree for Nitrogen8M Plus ENC Carrier Board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <195d7f07c75.da78a5cf8278.1708647163991154090@collabora.com>
Date: Thu, 27 Mar 2025 14:10:16 +0000
From: Martyn Welch <martyn.welch@...labora.com>
To: "Daniel Baluta" <daniel.baluta@...il.com>
Cc: "Shawn Guo" <shawnguo@...nel.org>,
	"Sascha Hauer" <s.hauer@...gutronix.de>,
	"Pengutronix Kernel Team" <kernel@...gutronix.de>,
	"Fabio Estevam" <festevam@...il.com>,
	"Rob Herring" <robh@...nel.org>,
	"Krzysztof Kozlowski" <krzk+dt@...nel.org>,
	"Conor Dooley" <conor+dt@...nel.org>,
	"kernel" <kernel@...labora.com>, "imx" <imx@...ts.linux.dev>,
	"linux-arm-kernel" <linux-arm-kernel@...ts.infradead.org>,
	"devicetree" <devicetree@...r.kernel.org>,
	"linux-kernel" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: imx8mp: Add device tree for Nitrogen8M Plus
 ENC Carrier Board


 ---- On Thu, 27 Mar 2025 13:00:13 +0000  Daniel Baluta <daniel.baluta@...il.com> wrote --- 
 > > +       mdio {
 > > +               compatible = "snps,dwmac-mdio";
 > > +               #address-cells = <1>;
 > > +               #size-cells = <0>;
 > > +
 > > +               ethphy0: ethernet-phy@4 {
 > > +                       compatible = "ethernet-phy-ieee802.3-c22";
 > > +                       reg = <4>;
 > > +                       eee-broken-1000t;
 > > +#if 0
 > > +                       interrupts-extended = <&gpio3 2 IRQ_TYPE_LEVEL_LOW>;
 > > +                       reset-gpios = <&gpio3 16 GPIO_ACTIVE_LOW>;
 > > +#endif
 > 
 > You should not have dead code in the final submission. If it is not
 > used just remove it.
 > 

Agh! Scanned though it a few times, somehow missed the ifdefs. Yup. wIll remove.

Thanks,

Martyn