linux-kernel - Re: [PATCH v2 0/2] Use memcpy_and_pad for jset_entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <vcyvvmuykkf2jylq7rlqzprmtoz3i5rc4cdro7zohg5n42toz4@3mmabyzvfkge>
Date: Thu, 27 Mar 2025 11:18:10 -0400
From: Kent Overstreet <kent.overstreet@...ux.dev>
To: Roxana Nicolescu <nicolescu.roxana@...tonmail.com>
Cc: linux-bcachefs@...r.kernel.org, linux-kernel@...r.kernel.org, 
	mmpgouride@...il.com, skhan@...uxfoundation.org, linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH v2 0/2] Use memcpy_and_pad for jset_entry_log->d init

On Thu, Mar 27, 2025 at 02:49:58PM +0000, Roxana Nicolescu wrote:
> This replaces the depracated usage of strncpy with memcpy_and_pad when
> used for initializing the d buffer of the struct jset_entry_log.
> 
> The other 2 usage of memcpy were also replaced by memcpy_and_pad.
> 
> Changes since v1:
> - since the dest buffer is not required to be NULL-terminated,
>   memcpy_and_pad is used instead of strscpy. This adds zeros at the end
>   of the buffer if there's extra room.
> - the same mechanism was done before in both __bch2_fs_log_msg() and
> bch2_trans_log_msg by zero-ing out the src buffer. The second patch
> replaces that logic with memcpy_and_pad to provide uniformity.
> 
> Roxana Nicolescu (2):
>   bcachefs: replace strncpy() with memcpy_and_pad in
>     journal_transaction_name
>   bcachefs: replace memcpy with memcpy_and_pad for jset_entry_log->d
>     buff
> 
>  fs/bcachefs/btree_trans_commit.c | 3 ++-
>  fs/bcachefs/btree_update.c       | 8 +++-----
>  2 files changed, 5 insertions(+), 6 deletions(-)

Thanks, series is applied.