linux-kernel - Re: [PATCH] spi: SPI_QPIC_SNAND should be tristate and depend on MTD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <174308893479.103696.13377418130348788517.b4-ty@kernel.org>
Date: Thu, 27 Mar 2025 15:22:14 +0000
From: Mark Brown <broonie@...nel.org>
To: Sricharan Ramabadhran <quic_srichara@...cinc.com>, 
 Md Sadre Alam <quic_mdalam@...cinc.com>, 
 Varadarajan Narayanan <quic_varada@...cinc.com>, 
 Geert Uytterhoeven <geert+renesas@...der.be>
Cc: linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: SPI_QPIC_SNAND should be tristate and depend on
 MTD

On Wed, 26 Mar 2025 15:22:19 +0100, Geert Uytterhoeven wrote:
> SPI_QPIC_SNAND is the only driver that selects MTD instead of depending
> on it, which could lead to circular dependencies.  Moreover, as
> SPI_QPIC_SNAND is bool, this forces MTD (and various related symbols) to
> be built-in, as can be seen in an allmodconfig kernel.
> 
> Except for a missing semicolon, there is no reason why SPI_QPIC_SNAND
> cannot be tristate; all MODULE_*() boilerplate is already present.
> Hence make SPI_QPIC_SNAND tristate, let it depend on MTD, and add the
> missing semicolon.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: SPI_QPIC_SNAND should be tristate and depend on MTD
      commit: d32c4e58545f17caaa854415f854691e32d42075

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark