linux-kernel - RE: [PATCH] PCI: layerscape: fix index passed to syscon_regmap_lookup_by_phandle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <AM6PR0402MB35281E7B8A7BEC907FFA8D198BA12@AM6PR0402MB3528.eurprd04.prod.outlook.com>
Date: Thu, 27 Mar 2025 15:32:18 +0000
From: Roy Zang <roy.zang@....com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Ioana Ciornei
	<ioana.ciornei@....com>, Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Krzysztof Wilczyński <kw@...ux.com>, Manivannan
 Sadhasivam <manivannan.sadhasivam@...aro.org>, Rob Herring <robh@...nel.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>, Frank Li <frank.li@....com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
CC: "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] PCI: layerscape: fix index passed to
 syscon_regmap_lookup_by_phandle_args



> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> On 27/03/2025 16:19, Ioana Ciornei wrote:
> > The arg_count variable passed to the
> > syscon_regmap_lookup_by_phandle_args() function represents the number
> > of argument cells following the phandle. In this case, the number of
> > arguments should be 1 instead of 2 since the dt property looks like
> > below.
> > 	fsl,pcie-scfg = <&scfg 0>;
> >
> > Without this fix, layerscape-pcie fails with the following message on
> > LS1043A:
> >
> > [    0.157041] OF: /soc/pcie@...0000: phandle scfg@...0000 needs 2,
> found 1
> > [    0.157050] layerscape-pcie 3500000.pcie: No syscfg phandle specified
> > [    0.157053] layerscape-pcie 3500000.pcie: probe with driver layerscape-
> pcie failed with error -22
> >
> > Fixes: 149fc35734e5 ("PCI: layerscape: Use
> > syscon_regmap_lookup_by_phandle_args")
>
> Uh, obviously, probably I thought the code is using
> of_property_read_u32_index(), but that's of_property_read_u32_array().
>
> Thanks.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Thank you Ioana for the quick patch fix.
Acked-by: Roy Zang <Roy.Zang@....com>

Roy

Download attachment "smime.p7s" of type "application/pkcs7-signature" (9794 bytes)