linux-kernel - Re: [PATCH] x86/tools: Drop unlikely definition from insn_decoder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b26a2a43-3c55-4086-88e2-64e65dcfbeb2@linuxfoundation.org>
Date: Fri, 28 Mar 2025 15:06:28 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Ingo Molnar <mingo@...nel.org>, Nathan Chancellor <nathan@...nel.org>,
 David Gow <davidgow@...gle.com>, Brendan Higgins <brendan.higgins@...ux.dev>
Cc: x86@...nel.org, Rae Moar <rmoar@...gle.com>,
 Sergio González Collado <sergio.collado@...il.com>,
 linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
 KUnit Development <kunit-dev@...glegroups.com>,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] x86/tools: Drop unlikely definition from
 insn_decoder_test

On 3/19/25 14:31, Ingo Molnar wrote:
> 
> * Nathan Chancellor <nathan@...nel.org> wrote:
> 
>> After commit c104c16073b7 ("Kunit to check the longest symbol length"),
>> there is a warning when building with clang because there is now a
>> definition of unlikely from compiler.h in tools/include/linux, which
>> conflicts with the one in the instruction decoder selftest.
>>
>>    arch/x86/tools/insn_decoder_test.c:15:9: warning: 'unlikely' macro redefined [-Wmacro-redefined]
>>       15 | #define unlikely(cond) (cond)
>>          |         ^
>>    tools/include/linux/compiler.h:128:10: note: previous definition is here
>>      128 | # define unlikely(x)            __builtin_expect(!!(x), 0)
>>          |          ^
>>    1 warning generated.
>>
>> Remove the second unlikely definition, as it is no longer necessary,
>> clearing up the warning.
>>
>> Fixes: c104c16073b7 ("Kunit to check the longest symbol length")
>> Signed-off-by: Nathan Chancellor <nathan@...nel.org>
>> ---
>>   arch/x86/tools/insn_decoder_test.c | 2 --
>>   1 file changed, 2 deletions(-)
> 
> I suppose this should be merged into the Kunit tree? The c104c16073b7
> commit is in -next currently.
> 
> Anyway:
> 
>    Acked-by: Ingo Molnar <mingo@...nel.org>
> 

Thanks Ingo.

David/Brendan, Okay to apply this for the next rc?

thanks,
-- Shuah