linux-kernel - Re: [PATCH] drm/bridge: anx7625: Simplify INTERFACE_CHANGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAC=S1ngKqPNwQphqD=31nJ_aLFQSDZTutRkXBoJQ2toh88uU4g@mail.gmail.com>
Date: Fri, 28 Mar 2025 13:05:49 +0800
From: Fei Shao <fshao@...omium.org>
To: Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>
Cc: Xin Ji <xji@...logixsemi.com>, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bridge: anx7625: Simplify INTERFACE_CHANGE_INT reg
 clear write

On Tue, Mar 25, 2025 at 4:14 PM Fei Shao <fshao@...omium.org> wrote:
>
> Simply clear the INTERFACE_CHANGE_INT register with 0 and replace the
> indirect `x & (~x)` pattern, since they are logically the same.
> No functional change.
>
> Signed-off-by: Fei Shao <fshao@...omium.org>
> ---

Hi,

I noticed that Xin sent out another patch [1] to completely remove the
block where this patch tries to modify, so feel free to ignore this if
applicable.

[1]: https://lore.kernel.org/all/20250327120558.1272081-1-xji@analogixsemi.com/

Regards,
Fei

>
>  drivers/gpu/drm/bridge/analogix/anx7625.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 0b97b66de577..df2d1dd95d01 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -1586,8 +1586,7 @@ static int anx7625_hpd_change_detect(struct anx7625_data *ctx)
>         }
>         DRM_DEV_DEBUG_DRIVER(dev, "0x7e:0x44=%x\n", intr_vector);
>         status = anx7625_reg_write(ctx, ctx->i2c.rx_p0_client,
> -                                  INTERFACE_CHANGE_INT,
> -                                  intr_vector & (~intr_vector));
> +                                  INTERFACE_CHANGE_INT, 0);
>         if (status < 0) {
>                 DRM_DEV_ERROR(dev, "cannot clear interrupt change reg.\n");
>                 return status;
> --
> 2.49.0.395.g12beb8f557-goog
>