linux-kernel - Re: [PATCH v2 1/2] dt-bindings: mailbox: add cix,sky1-mbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <815412a2-8537-4641-b528-30ad564c6dc1@kernel.org>
Date: Fri, 28 Mar 2025 08:12:58 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Guomin chen <guomin.chen@...tech.com>
Cc: Jassi Brar <jassisinghbrar@...il.com>, Rob Herring <robh@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, cix-kernel-upstream@...tech.com
Subject: Re: [PATCH v2 1/2] dt-bindings: mailbox: add cix,sky1-mbox

On 28/03/2025 04:13, Guomin chen wrote:
>>> +> +  cix,mbox-dir:
>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>> +    description: Direction of the mailbox (0:TX or 1:RX)
>>> +    enum: [0, 1]
>>
>> Respond to comments or implement them. Previous discussion was not
>> resolved - you did not respond. Sending the same with unfinished
>> discussion is not way to convince maintainer. Opposite: you will get
>> NAKed because you try to finish discussion and push your patch over the
>> wall.
>>
> Sorry, about your previous comments.
> 
> As previously mentioned, each Cixtech mailbox controller is unidirectional.
> Each mailbox supports 11 channels, which differ only in their transmission
> methods (e.g., FIFO, REG, doorbell). However, the transmission direction of
> all channels within the same mailbox is fixed and determined by the mailbox
> controller itself.
> 
> The Sky1 SoC contains 4 pairs (8 total) mailbox controllers. To identify
> whether a controller is TX or RX relative to the AP, the driver introduces
> the 'mbox-dir' property in DTS.

OK, that's fine, but as pointed in example - use strings 'rx' and 'tx',
not numbers.

Best regards,
Krzysztof