linux-kernel - Re: [RFC PATCH] wifi: mac80211: Replace strncpy() with strscpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5f6aba8a6c6e04fc118fd3b5679f534ef28adf7a.camel@sipsolutions.net>
Date: Fri, 28 Mar 2025 10:26:26 +0100
From: Johannes Berg <johannes@...solutions.net>
To: I Hsin Cheng <richard120310@...il.com>
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org, 
	skhan@...uxfoundation.org, linux-kernel-mentees@...ts.linux.dev
Subject: Re: [RFC PATCH] wifi: mac80211: Replace strncpy() with strscpy()

On Thu, 2025-03-27 at 22:11 +0800, I Hsin Cheng wrote:
> The name of vif which is "vif_name" should be NULL-terminated to be a
> valid string

And why should it be a "valid string"? This is just a buffer here in the
trace code. We don't even (and cannot) suggest how to print this, so I
think the userspace tool that does will just need to be careful, as with
anything else. Don't see any issue here.

johannes