[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <6b8583c9-3755-4b33-a454-261854e6cf2f@blaize.com>
Date: Fri, 28 Mar 2025 10:01:52 +0000
From: Neil Jones <neil.jones@...ize.com>
To: Nikolaos Pasaloukos <nikolaos.pasaloukos@...ize.com>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
James Cowgill
<james.cowgill@...ize.com>,
Matt Redfearn <matthew.redfearn@...ize.com>,
Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski
<brgl@...ev.pl>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will@...nel.org>
Cc: "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 1/3] dt-bindings: Document Blaize BLZP1600 GPIO driver
On 27/03/2025 11:27, Nikolaos Pasaloukos wrote:
> This is a custom silicon GPIO driver provided by VeriSilicon
> Microelectronics. It has 32 input/output ports which can be
> configured as edge or level triggered interrupts. It also provides
> a de-bounce feature.
> This controller is used on the Blaize BLZP1600 SoC.
>
> Signed-off-by: Nikolaos Pasaloukos <nikolaos.pasaloukos@...ize.com>
> ---
> .../bindings/gpio/blaize,blzp1600-gpio.yaml | 77 ++++++++++++++++++++++
> 1 file changed, 77 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/blaize,blzp1600-gpio.yaml b/Documentation/devicetree/bindings/gpio/blaize,blzp1600-gpio.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..8b7842331a22b7b9fbfa42b9c711da99227de2e4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/blaize,blzp1600-gpio.yaml
> @@ -0,0 +1,77 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/blaize,blzp1600-gpio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Blaize BLZP1600 GPIO controller
> +
> +description:
> + Blaize BLZP1600 GPIO controller is a design of VeriSilicon APB GPIO v0.2
> + IP block. It has 32 ports each of which are intended to be represented
> + as child noeds with the generic GPIO-controller properties as described
Typo here I assume, should be nodes ?
Also maybe better worded as:
Blaize BLZP1600 GPIO controller is an _implementation_ of the VeriSilicon APB GPIO v0.2 IP block
> + in this binding's file.
> +
> +maintainers:
> + - Nikolaos Pasaloukos <nikolaos.pasaloukos@...ize.com>
> + - James Cowgill <james.cowgill@...ize.com>
> + - Matt Redfearn <matt.redfearn@...ize.com>
> + - Neil Jones <neil.jones@...ize.com>
> +
> +properties:
> + $nodename:
> + pattern: "^gpio@[0-9a-f]+$"
> +
> + compatible:
> + enum:
> + - blaize,blzp1600-gpio
> +
> + reg:
> + maxItems: 1
> +
> + gpio-controller: true
> +
> + '#gpio-cells':
> + const: 2
> +
> + ngpios:
> + default: 32
> + minimum: 1
> + maximum: 32
> +
> + interrupts:
> + maxItems: 1
> +
> + gpio-line-names: true
> +
> + interrupt-controller: true
> +
> + '#interrupt-cells':
> + const: 2
> +
> +required:
> + - compatible
> + - reg
> + - gpio-controller
> + - '#gpio-cells'
> +
> +dependencies:
> + interrupt-controller: [ interrupts ]
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + gpio: gpio@...000 {
> + compatible = "blaize,blzp1600-gpio";
> + reg = <0x004c0000 0x1000>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + ngpios = <32>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
> + };
> +...
>
Powered by blists - more mailing lists